Dear Kristin,
You forgot of say what is the value of the $year. You just need to set it like this:
[wpv-if year="2012" evaluate="'[types field="publication-date" format="Y" style="text"][/types]' = '$year"]
Please let me know if you are satisfied with my answer and if I can help you with any other questions you might have.
